Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support HeadersInit for GaxiosRequest#headers #686

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

d-goog
Copy link
Contributor

@d-goog d-goog commented Feb 8, 2025

Description

This PR builds on #653 by allowing HeadersInit, a broader type of Headers, for GaxiosRequest#headers

Dependency: #685

Testing

Updated a test to show compatibility

Impact

Streamline the downstream migration experience while preserving the Headers type guarantee from GaxiosResponse.

🦕

@d-goog d-goog requested a review from a team as a code owner February 8, 2025 00:35
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 8, 2025
@d-goog d-goog changed the base branch from merge-headers-util to main February 8, 2025 00:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant