Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instructions for deploying using docker-compose #295

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sujithrpillai
Copy link

@sujithrpillai sujithrpillai commented Feb 15, 2025

feat(docker-compose): add Docker compose for GenAI toolkit.

Hi @kurtisvg,

Created a Docker-compose for genai-toolkit.

The update includes,

  1. config/init.sql - A sample Postgres init SQL , that will bring up -a Postgres DB with pre-populated sample table.
  2. config/tools.yaml - A sample tools yaml file for initialising the genai-toolbox with the sample Postgres db queries.
  3. docker-compose.yml - Docker compose file with genai-toolbox and Postgres DB.
  4. docs/en/how-to/deploy_toolbox_docker.md - Documentation that describes the deployment to docker environments with docker-compose.

Solution to issue #288

@sujithrpillai sujithrpillai requested a review from a team as a code owner February 15, 2025 06:21
@sujithrpillai sujithrpillai changed the title Docker-compose for GenAI toolkit feat(docker-compose): Docker-compose for GenAI toolkit Feb 15, 2025
@kurtisvg
Copy link
Collaborator

/gcbrun

@kurtisvg kurtisvg changed the title feat(docker-compose): Docker-compose for GenAI toolkit feat: add instructions for deploying using docker-compose Feb 19, 2025
Copy link
Collaborator

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather follow the directions for a specific tools.yaml (like we do in the quickstart), I think we should keep this example generic (like we did for the Cloud Run page) and have the user provide their own schema and tools.yaml

So it would be good to see the following sections:

  • Before you begin
  • Configure tools.yaml file
  • Deploy using Docker Compose
  • Connecting with Toolbox Client SDK

(Feel free to copy the sections from the Cloud Run page where it makes sense!)

@kurtisvg
Copy link
Collaborator

@sujithrpillai -- Thanks for opening a PR! Apologies for taking a few days to respond -- Monday was a holiday in the US.

Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants