Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: deprecate authsource in favor of authservice #297

Open
wants to merge 2 commits into
base: unmarshaller-ctx
Choose a base branch
from
Open

feat!: deprecate authsource in favor of authservice #297

wants to merge 2 commits into from

Conversation

Yuan325
Copy link
Contributor

@Yuan325 Yuan325 commented Feb 18, 2025 •
edited
Loading

Rename existing authSource to authService through deprecation. AuthService more clearly distinguishes it from Sources objects.

authSources will be converted into authServices after the unmarshalling process. A warning log is shown if authSources are used (for both within tools parameters and defining auth services):

2025-02-20T13:57:51.156025-08:00 WARN "`authSources` is deprecated, use `authServices` for parameters instead"
2025-02-20T13:57:51.156569-08:00 WARN "`authSources` is deprecated, use `authServices` instead"
2025-02-20T13:57:52.047584-08:00 INFO "Initialized 1 sources."
...

The manifest generated will continue to use authSources to keep compatibility with the sdks:

{
"serverVersion":"0.1.0",
"tools":{
  "test_tool2":{
    "description":"Use this tool to test\n",
    "parameters":[{
      "name":"user_id",
      "type":"string",
      "description":"Auto-populated from Google login",
      "authSources":["my-google-auth"]
      }]
    }
  }
}

Test cases with authSources are kept for compatibility. Will be removed when authSources are no longer supported.

@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@Yuan325 Yuan325 marked this pull request as ready for review February 19, 2025 18:57
@Yuan325 Yuan325 requested a review from a team as a code owner February 19, 2025 18:57
@Yuan325 Yuan325 changed the title chore!: deprecate authsource and add authservice chore: deprecate authsource and add authservice Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@Yuan325 Yuan325 changed the title chore: deprecate authsource and add authservice feat: deprecate authsource and add authservice Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@Yuan325 Yuan325 requested a review from kurtisvg February 19, 2025 19:14
@kurtisvg kurtisvg changed the title feat: deprecate authsource and add authservice feat!: deprecate authsource in favor of authservice Feb 19, 2025
kurtisvg
kurtisvg requested changes Feb 19, 2025
View reviewed changes
@Yuan325 Yuan325 changed the base branch from main to unmarshaller-ctx February 20, 2025 22:02
@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

@Yuan325 Yuan325 requested a review from kurtisvg February 20, 2025 22:02
@github-actions GitHub Actions
Copy link
Contributor

🔎 Preview at https://googleapis.github.io/genai-toolbox/previews/PR-297/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg Awaiting requested review from kurtisvg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuan325 @kurtisvg