-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Request
Revamp
#1938
Open
d-goog
wants to merge
11
commits into
main
Choose a base branch
from
request-revamp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat!: Request
Revamp
#1938
+795
−762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Headers` in Node v18 are not case-insensitive
…brary-nodejs into request-revamp
Warning: This pull request is touching the following templated files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a large refactor of the auth library's internals with sweeping improvements in UX, correctness, performance, security, and scalability.
Examples:
fetch
API conventionsresponseType
parameter from Gaxios requestsHeaders
Testing
All existing tests pass and enhanced numerous throughout the codebase.
Impact
This revamp brings number of improvements to library:
Headers
, while allowing the open, flexibleHeadersInit
for requests.RequestInit
body types, users can omit certain headers, such ascontent-type
Request
,Headers
,URLSearchParams
, etc.)/Additional Information
While a large PR, most of the changes are internal and doesn't affect external API consumption much outside from
Headers
consistency and Node 18'sHeaders
are not case-insensitive when compared in tests (which required a lot of lower-casing header names)A follow-up PR will add
fetch
support.🦕