feat(pubsub/pstest): support listening on custom host #11586
+128
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
larryanz
changed the title
|
Hi @hongalex, please help to take a look |
hongalex
reviewed
Feb 12, 2025
larryanz
force-pushed
the
feat/support-listening-hostname-0000
branch
from
c24aa0d to
a20f447
Compare
hongalex
reviewed
Feb 13, 2025
pubsub/pstest/fake.go
Outdated
| // at the specified address (host and port). Before starting the server, the | ||
| // provided callback is called to allow caller to register additional fakes into | ||
| // grpc server. | ||
| func NewServerWithCallback(address string, callback func(*grpc.Server), opts ...ServerReactorOption) *Server { |
There was a problem hiding this comment.
Changing the signature of NewServerWithCallback is a breaking change, and although we do allow for breaking changes within the fake, we should probably avoid it when it is easy to do so. Can you revert this change?
hongalex
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
larryanz
force-pushed
the
feat/support-listening-hostname-0000
branch
from
9fee3f3 to
ab6fe46
Compare
|
hi @hongalex , seems the CI fails, could you please try it again? |
hongalex
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #11569, this PR adds support of pstest test server to listening on custom hosts rather than only localhost.