-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix sum implementation WIP #14
Draft
raphlinus
wants to merge
8
commits into
main
Choose a base branch
from
prefix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Oct 27, 2021
-
Sorta works but deadlocks on larger inputs.
Configuration menu - View commit details
-
Copy full SHA for 274d151 - Browse repository at this point
Copy the full SHA 274d151View commit details -
Make storage barriers uniform control flow
Still doesn't fix deadlocks tho :/
Configuration menu - View commit details
-
Copy full SHA for 2800b73 - Browse repository at this point
Copy the full SHA 2800b73View commit details
Commits on Nov 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5fc557c - Browse repository at this point
Copy the full SHA 5fc557cView commit details
Commits on Nov 2, 2021
-
Fastest results on AMD at workgroup = 1024. Note, this has atomicOr workaround for correctness. Also note, not all targets will support a workgroup of this size; on shipping, we'd need to query and select at runtime.
Configuration menu - View commit details
-
Copy full SHA for 17094ab - Browse repository at this point
Copy the full SHA 17094abView commit details -
Do a small sequential scan at the leaf of the hierarchy. That amortizes both the workgroup-scope tree reduction and the (still sequential) decoupled look-back to a larger number of inputs. Note: this falls short of a real performance evaluation because there's no attempt to warm up the GPU clock. But it's valid as a very rough swag.
Configuration menu - View commit details
-
Copy full SHA for 8174880 - Browse repository at this point
Copy the full SHA 8174880View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93ad8ee - Browse repository at this point
Copy the full SHA 93ad8eeView commit details
Commits on Nov 3, 2021
-
Performance measurement requires keeping the GPU busy. That means not copying results back to CPU and doing verification there.
Configuration menu - View commit details
-
Copy full SHA for 697ea4e - Browse repository at this point
Copy the full SHA 697ea4eView commit details
Commits on Nov 4, 2021
-
Naga will accept ordinary loads and stores to atomic types, but tint will not.
Configuration menu - View commit details
-
Copy full SHA for 87e5b20 - Browse repository at this point
Copy the full SHA 87e5b20View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.