Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test at multiple locations, from cartesian product of coords in fvar #10

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Test at multiple locations, from cartesian product of coords in fvar #10

merged 1 commit into from
Jan 28, 2025

Conversation

Hoolean
Copy link
Collaborator

@Hoolean Hoolean commented Jan 24, 2025

Closes #6, although there is more to think about - reasonable limits on the maximum number of locations, variation data not at instances or extremes - but I will spin out separate issues for these.

@RickyDaMa RickyDaMa marked this pull request as ready for review January 28, 2025 15:53
@Hoolean
Copy link
Collaborator Author

Hoolean commented Jan 28, 2025

This is a good starter approach, and improves on our original proof-of-concept: it is not hardcoded and stretches beyond the named instances.

Future improvements for the code here have been spun out into #12 and #14.

@RickyDaMa RickyDaMa merged commit d0f65d5 into main Jan 28, 2025
4 checks passed
@RickyDaMa RickyDaMa deleted the variations branch January 28, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickyDaMa RickyDaMa RickyDaMa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test variation data
2 participants
@Hoolean @RickyDaMa