Add Custom Fields #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to add custom fields with a namespace to the RSS feed.
|
I guess we will need to drop go1.7 support in order to include this. @elithrar do you think it's too soon to do that, or probably fine? It's almost 2 years old now |
|
Yes, we should require 1.7 and cut a new release for that, as well as
update the Travis config to match.
…On Thu, Jun 14, 2018 at 8:13 AM Kamil Kisiel ***@***.***> wrote:
I guess we will need to drop go1.7 support in order to include this.
@elithrar <https://github.com/elithrar> do you think it's too soon to do
that, or probably fine? It's almost 2 years old now
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcNYsyE7GqmxcJwWZa5_k7q6poCqrks5t8n2igaJpZM4UneQH>
.
|
|
You mean require 1.8? That seems to be the earliest version with |
|
Yes, sorry! 1.8+ is fine. We’re at 1.10 and 1.11 in August.
…On Thu, Jun 14, 2018 at 12:57 PM Kamil Kisiel ***@***.***> wrote:
You mean require 1.8? That seems to be the earliest version with xml.Attr
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABIcC-YzMGDghp0l5xnkelknmQ7OFMpks5t8sA3gaJpZM4UneQH>
.
|
|
Cool! I just realized that I need to comment the functions for the GoDoc, so I'll do that and make another commit. Feel free to request any other changes. |
|
Great. I just updated |
|
This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that addresses issue #25.