Workaround openai issue with temperature: 0 being omitted from request #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a workaround for [this GitHub discussion][gh], describing how chat completion requests which explicitly set temperature = 0 are marshalled to JSON incorrectly (due to the 0 being indistinguishable from the zero value of the field). To do so we add a custom unmarshal method which checks whether the field was defined and set to zero, and explicitly set the temperature to `math.SmallestNonzeroFloat32` in such cases. This isn't perfect but is likely to get very similar results in practice. [gh]: sashabaranov/go-openai#9 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workaround for this GitHub discussion, describing
how chat completion requests which explicitly set temperature = 0 are
marshalled to JSON incorrectly (due to the 0 being indistinguishable
from the zero value of the field).
To do so we add a custom unmarshal method which checks whether the field
was defined and set to zero, and explicitly set the temperature to
math.SmallestNonzeroFloat32in such cases. This isn't perfect but islikely to get very similar results in practice.