Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document k6 cloud run --local-execution #1732

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Sep 19, 2024

What?

We have introduced the k6 cloud run --local-execution flag to supersede k6 run -o cloud, which is now considered (but not communicated as) deprecated.

I have made the changes I found obvious, let me know if you think we should go farther, and modify further docs, or add more info 🙇🏻

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.

@oleiade oleiade self-assigned this Sep 19, 2024
@oleiade oleiade added the Area: OSS Content Improvements or additions to community/oss documentation label Sep 19, 2024
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a small comment about the admonition, and I found another instance of the command on this file that we should probably change as well: https://github.com/grafana/k6-docs/blob/document_local_execution/docs/sources/next/set-up/set-up-distributed-k6/usage/k6-operator-to-gck6.md.

docs/sources/next/results-output/real-time/cloud.md Outdated Show resolved Hide resolved
@heitortsergent
Copy link
Collaborator

I created a PR to update the Grafana Cloud k6 docs as well: https://github.com/grafana/website/pull/21806

@oleiade
Copy link
Member Author

oleiade commented Sep 23, 2024

Regarding the operator changes, I would prefer to not touch it for the time being and reasses later if the operator does support the new mode of operation 🙇🏻

@oleiade oleiade requested review from heitortsergent and removed request for joanlopez September 23, 2024 08:19
@olegbespalov olegbespalov mentioned this pull request Sep 23, 2024
45 tasks
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@oleiade oleiade merged commit 0ea4b11 into main Sep 24, 2024
5 checks passed
@oleiade oleiade deleted the document_local_execution branch September 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants