Allow skipping spans for metric generation #4728
Open
+344
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxbk
force-pushed
the
allow-skipping-metricsgen
branch
2 times, most recently
from
e32a83d to
988b46f
Compare
yvrhdn
reviewed
Feb 21, 2025
flxbk
force-pushed
the
allow-skipping-metricsgen
branch
2 times, most recently
from
6d75304 to
1533001
Compare
flxbk
requested review from
joe-elliott,
mdisibio,
mapno,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
flxbk
force-pushed
the
allow-skipping-metricsgen
branch
from
1533001 to
ca900fe
Compare
|
Rebasing to get CI to run (via #4751). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR makes it possible for distributor clients to indicate that the spans in a write request should not be considered for metrics generation (e.g. because metrics have been generated for these spans elsewhere already, and reprocessing them would lead to incorrect overall metric values).
The spans contained in requests marked this way will still be forwarded to generators so they can be ingested into the localblocks processor. The spanmetrics and service-graph processors will however be skipped.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]