-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package exports for Vercel Edge Runtime support #441
Package exports for Vercel Edge Runtime support #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this covered by default
? 🫠
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 46.55% 46.55%
=======================================
Files 19 19
Lines 5595 5595
Branches 222 222
=======================================
Hits 2605 2605
Misses 2988 2988
Partials 2 2
☔ View full report in Codecov by Sentry. |
@balazsorban44 Can you comment on this question or suggest someone from @vercel ? |
044d696
to
5ed1436
Compare
5eeb2bb
to
da6fa8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Also, please accept the invitation to join @grammyjs.
Consider signing your commits in the future. We usually require this, but I used admin rights to merge anyway now. |
@all-contributors add @PonomareVlad for the extensive testing and the code to bring grammY to a new platform |
I've put up a pull request to add @PonomareVlad! 🎉 |
Details
Vercel Edge Runtime need a different key in
"exports"
for web targetIf we add a
"browser"
target, Vercel Edge Runtime can automatically switch to web build instead specifying it manually:Also, this can solve incompatibility for some plugins that not depend on Node internal packages, but uses default import for core grammY package
Might be able to fix
How to test
I think we need to test this change on other platforms before merging 🌚
Where need to test
Deno Deploy(same as Deno)Supabase Edge Functions(same as Deno)