Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests from deno.land to JSR #651

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Migrate tests from deno.land to JSR #651

merged 9 commits into from
Oct 28, 2024

Conversation

KnorpelSenf
Copy link
Member

This PQ

  • fixes up the old context types tests and aligns them with the composer type tests
  • migrates the test deps to JSR
  • stops depending on various deno.land deps to mock types and uses npm: imports instead

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (f31feed) to head (e8e8f9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files          19       19           
  Lines        6374     6374           
  Branches      352      352           
=======================================
  Hits         3031     3031           
  Misses       3339     3339           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnorpelSenf KnorpelSenf changed the title Migrate test from deno.land to JSR Migrate tests from deno.land to JSR Oct 27, 2024
test/context.type.test.ts Outdated Show resolved Hide resolved
@KnorpelSenf
Copy link
Member Author

I am trying to contribute IsMutuallyAssignable to @std: denoland/std#6154

Let's see what they think of it. If they merge, we can remove our own declaration of the type, and rely on @std instead.

Copy link
Contributor

@Loskir Loskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KnorpelSenf KnorpelSenf merged commit 550691e into main Oct 28, 2024
6 checks passed
@KnorpelSenf KnorpelSenf deleted the migrate-type-tests branch October 28, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants