Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Container is falsy' bug due to Babel upgrade #2175

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Sep 18, 2024

Description

What we were doing worked, but was broken by Babel's latest patch release; thanks to @nckswt for tracking it down in benjie/ouch-my-finger#16 (comment) and narrowing down that it works fine with @babel/[email protected] but surfaces the error in @babel/[email protected]

This PR reworks our solution based on the approach outlined in babel/babel#15544 (comment)

Performance impact

Unknown.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: c69b2fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
eslint-plugin-graphile-export Patch
graphile-export Patch
postgraphile Patch
pgl Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit d9d175b into main Sep 18, 2024
36 checks passed
@benjie benjie deleted the workaround-babel-bug branch September 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant