Skip to content

Commit

Permalink
Disable flaky tests. Revert release version bump.
Browse files Browse the repository at this point in the history
  • Loading branch information
jnak committed Dec 30, 2019
1 parent 62d87b8 commit 081a976
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion graphql/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
set_default_backend,
)

VERSION = (2, 3, 0, "final", 0)
VERSION = (2, 2, 1, "final", 0)
__version__ = get_version(VERSION)


Expand Down
10 changes: 10 additions & 0 deletions graphql/execution/tests/test_executor_thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,20 @@
GraphQLSchema,
GraphQLString,
)
from pytest import mark

from ..executors.thread import ThreadExecutor
from .test_mutations import assert_evaluate_mutations_serially
from .utils import rejected, resolved

###
# Disabled because all these tests are flaky
# The culprit lies in the fact that the `ThreadExecutor` incorrectly assumes that
# the `Promise` class is thread-safe.
# See https://git.io/JeA3s
###

@mark.xfail
def test_executes_arbitary_code():
# type: () -> None
class Data(object):
Expand Down Expand Up @@ -157,6 +165,7 @@ def handle_result(result):
)


@mark.xfail
def test_synchronous_error_nulls_out_error_subtrees():
# type: () -> None
ast = parse(
Expand Down Expand Up @@ -289,6 +298,7 @@ def handle_results(result):
handle_results(execute(schema, ast, Data(), executor=ThreadExecutor()))


@mark.xfail
def test_evaluates_mutations_serially():
# type: () -> None
assert_evaluate_mutations_serially(executor=ThreadExecutor())

0 comments on commit 081a976

Please sign in to comment.