Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support queries for multiple schemas in the same file #3411
base: main
Are you sure you want to change the base?
Support queries for multiple schemas in the same file #3411
Changes from 9 commits
ecd29f8
b20c7ed
ffca1f7
bbc8a6e
196d830
5dcd471
5148707
63e82ba
12acf3e
935ae8a
6b9582c
b956407
d09f46d
80a3541
92f2c7b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rename this to
getProjectForDocument
? just so people don't assume this only works with queries, as it should also work with SDLThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! I've also resolved the new conflicts but fyi, there's a problem with
cspell
on commit because it finds unknown words in.vscode/settings.json
.Check warning on line 259 in packages/graphql-language-service-server/src/GraphQLLanguageService.ts
packages/graphql-language-service-server/src/GraphQLLanguageService.ts#L259