Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: treeshakable kind enum #4270

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

refactor: treeshakable kind enum #4270

wants to merge 17 commits into from

Conversation

jasonkuhrt
Copy link

@jasonkuhrt jasonkuhrt commented Oct 29, 2024 •
edited
Loading

closes #4253

@jasonkuhrt jasonkuhrt requested a review from a team as a code owner October 29, 2024 14:56
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jasonkuhrt jasonkuhrt changed the base branch from 16.x.x to main October 29, 2024 14:56
@jasonkuhrt jasonkuhrt mentioned this pull request Oct 29, 2024
Closed
@jasonkuhrt jasonkuhrt closed this Oct 29, 2024
@jasonkuhrt
Copy link
Author

Duplicate of #4268.

@jasonkuhrt jasonkuhrt reopened this Nov 9, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit a9982fa
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/672f7b334ded0700082066d1
😎 Deploy Preview https://deploy-preview-4270--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonkuhrt
Copy link
Author

@JoviDeCroock needed to focus on other things so #4268 was closed. I am re-opening this PR therefore to finish that work.

yaacovCR
yaacovCR approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@yaacovCR yaacovCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to take this approach for all enums?

@jasonkuhrt
Copy link
Author

jasonkuhrt commented Nov 10, 2024 •
edited
Loading

Yeah I think there's nothing to lose by doing that and it would be a better DX (e.g. all enum have type level name spaces, consistent) plus be tree-shakable.

If you agree then I can update this PR to change them all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacovCR yaacovCR yaacovCR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonkuhrt @yaacovCR