Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vnet] configure split DNS for VNet on Windows #51739

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

nklaassen
Copy link
Contributor

@nklaassen nklaassen commented Feb 1, 2025

Part of RFD 195.

With these changes, VNet now configures split DNS on Windows so that queries for all VNet DNS zones are handled by VNet's DNS nameserver.

At this point, tsh vnet actually works on Windows. You still have to manually install the Windows service and wintun.dll, but this will be handled in the Connect installer later on.

@nklaassen nklaassen added no-changelog Indicates that a PR does not require a changelog entry vnet backport/branch/v17 labels Feb 1, 2025
@github-actions github-actions bot requested review from gzdunek and ryanclark February 1, 2025 01:00
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch 2 times, most recently from 7967582 to 0bd1d87 Compare February 3, 2025 20:40
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-upstream branch from 52592fb to 3902016 Compare February 5, 2025 20:33
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch from 0bd1d87 to 580fbb7 Compare February 5, 2025 20:34
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-upstream branch from 3902016 to d9c4150 Compare February 5, 2025 22:15
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch from 580fbb7 to 61bea76 Compare February 5, 2025 22:15
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-upstream branch from d9c4150 to 929f4fa Compare February 5, 2025 23:15
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch from 61bea76 to 4cbc5ab Compare February 5, 2025 23:15
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-upstream branch from 929f4fa to 75b5d9b Compare February 6, 2025 00:40
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch from 4cbc5ab to 50b89dc Compare February 6, 2025 00:40
@nklaassen
Copy link
Contributor Author

friendly ping @gzdunek

Base automatically changed from nklaassen/windows-dns-upstream to master February 6, 2025 17:59
@nklaassen nklaassen force-pushed the nklaassen/windows-dns-configuration branch from 50b89dc to 9a4a181 Compare February 6, 2025 18:10
@nklaassen nklaassen enabled auto-merge February 6, 2025 18:19
@nklaassen nklaassen added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit b235426 Feb 6, 2025
41 checks passed
@nklaassen nklaassen deleted the nklaassen/windows-dns-configuration branch February 6, 2025 18:50
@public-teleport-github-review-bot

@nklaassen See the table below for backport results.

Branch Result
branch/v17 Failed

nklaassen added a commit that referenced this pull request Feb 6, 2025
nklaassen added a commit that referenced this pull request Feb 6, 2025
nklaassen added a commit that referenced this pull request Feb 7, 2025
nklaassen added a commit that referenced this pull request Feb 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/md vnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants