-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vnet] configure split DNS for VNet on Windows #51739
Merged
Merged
+110
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
no-changelog
Indicates that a PR does not require a changelog entry
vnet
backport/branch/v17
labels
Feb 1, 2025
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
2 times, most recently
from
February 3, 2025 20:40
7967582
to
0bd1d87
Compare
ryanclark
approved these changes
Feb 4, 2025
nklaassen
force-pushed
the
nklaassen/windows-dns-upstream
branch
from
February 5, 2025 20:33
52592fb
to
3902016
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
from
February 5, 2025 20:34
0bd1d87
to
580fbb7
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-upstream
branch
from
February 5, 2025 22:15
3902016
to
d9c4150
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
from
February 5, 2025 22:15
580fbb7
to
61bea76
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-upstream
branch
from
February 5, 2025 23:15
d9c4150
to
929f4fa
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
from
February 5, 2025 23:15
61bea76
to
4cbc5ab
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-upstream
branch
from
February 6, 2025 00:40
929f4fa
to
75b5d9b
Compare
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
from
February 6, 2025 00:40
4cbc5ab
to
50b89dc
Compare
friendly ping @gzdunek |
gzdunek
approved these changes
Feb 6, 2025
nklaassen
force-pushed
the
nklaassen/windows-dns-configuration
branch
from
February 6, 2025 18:10
50b89dc
to
9a4a181
Compare
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Feb 6, 2025
Backport #51739 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Feb 6, 2025
Backport #51739 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Feb 7, 2025
Backport #51739 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Feb 7, 2025
Backport #51739 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Backport #51739 to branch/v17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v17
no-changelog
Indicates that a PR does not require a changelog entry
size/md
vnet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RFD 195.
With these changes, VNet now configures split DNS on Windows so that queries for all VNet DNS zones are handled by VNet's DNS nameserver.
At this point,
tsh vnet
actually works on Windows. You still have to manually install the Windows service and wintun.dll, but this will be handled in the Connect installer later on.