Use new autoupdate APIs in discovery service #51758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
force-pushed
the
hugo/use-right-version-in-discover
branch
from
d1cda36 to
f88f765
Compare
hugoShaka
changed the title
hugoShaka
commented
Feb 3, 2025
Comment on lines
-60
to
-64
| // Name implements Getter | ||
| func (g ProxyVersionGetter) Name() string { | ||
| return g.name | ||
| } | ||
|
|
There was a problem hiding this comment.
Narrator voice: Name was not, in fact, part of the version.Getter interface.
creack
changed the title
hugoShaka
force-pushed
the
hugo/use-right-version-in-discover
branch
from
309d3c5 to
eb4b739
Compare
hugoShaka
force-pushed
the
hugo/use-right-version-in-discover
branch
from
eb4b739 to
8f5db63
Compare
tigrato
approved these changes
Feb 6, 2025
Co-authored-by: Tiago Silva <[email protected]>
lib/web/integrations_awsoidc.go
Outdated
| if err != nil { | ||
| return "", trace.Wrap(err) | ||
| h.logger.ErrorContext(r.Context(), "Cannot read autoupdate target version", "error", err) |
There was a problem hiding this comment.
Before we were terminating the flow on error. Should we do the same? Or should we default to current's teleport.Version ?
There was a problem hiding this comment.
That's a very good question.
With the new autoupdate system I think that we are adding more moving parts and increasing the probability of errors when getting the autoupdate version. I think we should always fallback to the local proxy version in case of error because:
- it's a better UX to get the install script working instead of a random error "token might be expired", you have a working node/integration
- by definition we still enable autoupdates, so potential version drifts will get corrected over time, the core feature of updating the nodes/agents is not affected
Based on this discussion I changed the join scripts to also fallback to their own version instead of failing.
marcoandredinis
approved these changes
Feb 6, 2025
public-teleport-github-review-bot
bot
removed the request for review
from creack
public-teleport-github-review-bot
bot
removed request for
sclevine and
vapopov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces every direct usage of the proxy's autoupdate channels from RFD 109 by
agentAutoUpdateVersion()which will look at the RFD-184 autoupdate_agent_rollout resource first, then fallback to RFD-109 proxy channels.Fixes an issue found during the autoupdate test plan: discovery service and discover UI don't use the version from
autoupdate_agent_rollout, this causes version inconsistencies.There are two gotchas in the PR:
version.Getter.GetVersion()returned versions with the leading "v" whileagentAutoUpdateVersion()doesn't have the leading v.Changelog: Scripts installing nodes no longer fail if they cannot discover the autoupdate version, they send a warning and use the version from their own Teleport binary.
Part of: RFD-184
Goal (internal): https://github.com/gravitational/cloud/issues/10289