[buddy] gate RBAC creation in the tbot Helm chart behind a dedicated value #51919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #51181. K8S `Role` & `RoleBinding` are created by default. Their creation does not depends on the `ServiceAccount` creation anymore.
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
hugoShaka
changed the title
Role creation is optional
|
Amplify deployment status
|
hugoShaka
changed the title
strideynet
approved these changes
Feb 6, 2025
tigrato
approved these changes
Feb 6, 2025
public-teleport-github-review-bot
bot
removed request for
r0mant,
marcoandredinis,
mmcallister,
zmb3,
xinding33 and
ptgott
zmb3
approved these changes
Feb 6, 2025
hugoShaka
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buddy PR for: #51500
Fixes #51181.
This is a breaking change, do not backport.
Changelog: The
tbotHelm chart now creates RBAC resources based on therbac.createvalue instead ofserviceAccount.create. This is a breaking change if you were settingserviceAccount.create: falsein v17. To keep the previous behaviour you must now also setrbac.create: false.