Machine ID: Per-ouput certificate_ttl and renewal_interval
#51956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me` struct These values are always required together, and moving them into a struct will make it more straightforward to override them per-service/output.
boxofrad
commented
Feb 7, 2025
| } | ||
|
|
||
| if l.TTL < l.RenewalInterval && !oneShot { | ||
| log.WarnContext( |
There was a problem hiding this comment.
I re-homed these warnings from BotConfig.CheckAndSetDefaults.
Ideally, we'd return an error (so they'd get wrapped with the service[%d] prefix) but decided not to as making this a "hard fail" would be a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #51560 by adding
certificate_ttlandrenewal_intervaloptions to all tbot services/outputs.