[v17] Make sure we don't break the role editor for some preset roles, add support for GH organizations #51959
+371
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport for GH organizations (#51608) * Add more fields to the role editor * Review * Make sure we don't break the role editor for some preset roles Adds a test that verifies that the built-in roles, as pulled from our Go source codes, can be unambiguously translated to the standard editor model. Also adds one currently missing field (`github_organizations`). * Fix type-check * Also remove the now redundant comments in presets.go * Post-merge fix * Review * Increase the test timeout * Increase the test timeout even more * Attempt to work around the problem with compiler output * Switch from testPathIgnorePatterns to watchPathIgnorePatterns * Add newline to end of Makefile * Wrap preset role tests into a separate describe block * Change of approach: check in the generated file * Revert an accidental change * One more update to the preset roles * Final touches --------- Co-authored-by: Rafał Cieślak <[email protected]>
bl-nero
added
the
no-changelog
|
Manually tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #51608 to branch/v17
Manually resolved imports in
presets_test.goand recreated the actual role dump file for v17.