gppa-use-acf-choice-label.php: Fixed PHP fatal error when ACF field set return value as return Both (array).
#1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set return value as return `Both (array)`.
saifsultanc
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Looks to be working well now! Good job.
I just wonder if we could add some extensibility to the snippet to make it work for "Both" scenarios in "Both" ways as well. Maybe have a different CSS class for this, and then return the both data as label : value.
For now this is good, but just a thought.
Marking approved. Final 👀 from @claygriffiths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2846332119/77984
Summary
User is attempting to grab the Label of an ACF field using this snippet: https://gravitywiz.com/snippet-library/gppa-use-acf-choice-label/.
This works as intended when the ACF field's return value is set to
label, but their field is set toBoth (Array), so the following error is being thrown.Uncaught Error: str_contains(): Argument #1 ($haystack) must be of type string, array given in /wp-includes/blocks.php on line 1817This PR fixes this fatal error.