Reduce the number of queries by caching schema info #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the new PR from rails - rails/rails#45381, this will be even faster for gitlab: |
gregnavis
requested changes
Oct 14, 2022
fatkodima
force-pushed
the
schema-cache
branch
from
3845bce
to
2755369
Compare
|
Renamed the class. |
|
@fatkodima, please rebase and it's good to merge! |
fatkodima
force-pushed
the
schema-cache
branch
from
2755369
to
2d30756
Compare
|
@gregnavis Rebased. |
fatkodima
force-pushed
the
schema-cache
branch
from
2d30756
to
0273dbb
Compare
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
66ef32f
to
fc73681
Compare
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
168d951
to
d322a6e
Compare
gregnavis
added
the
improvement
|
@gregnavis Would you like to also add this to 2.0? I can update it then. |
gregnavis
force-pushed
the
master
branch
3 times, most recently
from
afcda83
to
4ee897c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99.
I was able to run
active_record_doctoron 2 OSS projects:discourse(medium sized) andgitlab(large sized).Discourse
Before
Num of queries:
6771Runtime of
active_record_doctor(checks only, not including app eager loading):8.53sTotal runtime (of the
rake active_record_doctor):15.74sAfter
Num of queries:
1739Runtime of
active_record_doctor:2.55s🔥Total runtime :
9.3sGitlab
Before
Num of queries:
31499Runtime of
active_record_doctor:125.9sTotal runtime:
2:36.17mAfter
Num of queries:
10697Runtime of
active_record_doctor:38.53s🔥 🔥 🔥Total runtime:
1:13.80m