Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added followSymlink for find-command #141

Merged
merged 2 commits into from
Mar 26, 2017

Conversation

junjihashimoto
Copy link
Contributor

Hi,

Currently, find-command can not follow symlink like 'find -L'.
See this code.
This PR adds followSymlink-flag to follow symlinks.

@junjihashimoto
Copy link
Contributor Author

Sorry for not reading #21.
(Now I read it.)

If there is a DSL and its implementation for find-command, it will be better than this PR.

I suppose the DSL will change filter-options and search-area of file system.

In use case of changing filter-options, we can use findWhen, so we do not need additional function for shelly.

In use case of changing search-area, we can refer to linux-find-command.
In this manual, the option of search-area is just whether to follow symlinks or not.

I think we need just a option of following symlinks and do not need DSL.
(To solve my job, I need this option. If you have any alternative solution, please tell me.)

@junjihashimoto
Copy link
Contributor Author

Any suggestions are welcome.
Should I implement DSL version of symlink?

@gregwebs
Copy link
Owner

Thanks for the PR. I agree that something find-specific would be better, but this seems fine. Would you like me to merge it now?

@junjihashimoto
Copy link
Contributor Author

I'd love to!
It would be a great help.
I am using my branch.

@gregwebs gregwebs merged commit 5c3b1aa into gregwebs:master Mar 26, 2017
@junjihashimoto
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants