Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special crossword series #2478

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

andrew-nowak
Copy link
Member

@andrew-nowak andrew-nowak commented Aug 6, 2024

Why are you doing this?

Adds support for special crosswords.
This is a new series where crosswords which don't fit a regular schedule can live. (eg. the crosswords that are published in the paper's summer puzzle supplement could go here, and not disrupt the daily/weekly crossword series schedules). The puzzles themselves will be similar in format to the regular quicks or cryptics.

Changes

  • Upgrade content-api-models to latest version, which includes the Special crossword type
  • Add special crossword type to the crosswords enum

As the special series will have differing grid sizes throughout the series, we also need a corresponding change to react-crossword which will scale the grid according to the number of cells, rather than according to the crossword type - ie. port this frontend PR to react-crossword. That change doesn't need to block this PR however

Screenshots

Before After

@andrew-nowak andrew-nowak requested a review from a team as a code owner August 6, 2024 09:18
@andrew-nowak andrew-nowak marked this pull request as draft August 6, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant