improves the error flow in updateUploadStatusTable #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently we recover from the uploadAttempt before we continue on the happy path, which means that the future is turned from a failure to a success, but holding the exception from the previous failure, which of course fails the pattern match. Instead handle both success and failure cases by using a `transformWith`, which provides the bonus that we can handle the table update failure cases together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Currently we recover from the uploadAttempt before we continue on the happy path, which means that the future is turned from a failure to a success, but holding the exception from the previous failure, which of course fails the pattern match, leaving us with a very confusing stack trace. Instead handle both success and failure cases by using a
transformWith, which provides the bonus that we can handle the table update failure cases togetherHow should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?