t1836: Fixing "Cannot download" button padding #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonmcgurk
changed the title
| class="download-icon-label" | ||
| gr-tooltip="Downloading non-free images requires a lease" | ||
| > | ||
| class="cannot-download-icon-label" |
There was a problem hiding this comment.
this works, but did you consider using the side-padded class that the other buttons use to add padding? it would mean one less CSS rule to maintain for just this version of the button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR addresses an inconsistency in padding between the "Download" and "Cannot Download" buttons. Previously, the "Cannot Download" button lacked proper padding compared to the "Download" button. To resolve this, I have created a specific CSS rule for class corresponding to the "Cannot Download" button, ensuring that it now has consistent padding.
Before:
After:
How should a reviewer test this change?
Verify that the "Download" button and the "Cannot Download" button have consistent padding when selecting an image with public rights and an image with no rights.
How can success be measured?
Ensuring that the padding for the "Cannot Download" button is visually consistent with the "Download" button across all scenarios.
Who should look at this?
Tested? Documented?