Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code and unused elasticsearch dependency #4366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrew-nowak
Copy link
Member

@andrew-nowak andrew-nowak commented Nov 4, 2024

What does this change?

This code appears unused, and is the only usage of an outdated elasticsearch dependency (all active elasticsearch queries use elastic4s, which depends on a different and up-to-date elasticsearch dependency)

How should a reviewer test this change?

Does the app compile? If so, all should be fine since this only removes code.

Technically this code might be loaded at runtime? I haven't seen any evidence of this from a (admittedly very brief) look around, I'd be pretty shocked if that was the case. Deploy to TEST to be sure?

How can success be measured?

Who should look at this?

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@andrew-nowak andrew-nowak marked this pull request as ready for review November 11, 2024 11:52
@andrew-nowak andrew-nowak requested review from a team as code owners November 11, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant