Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Perform EC2 deployments via CloudFormation #1156

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

akash1810
Copy link
Member

What does this change?

Uses the new GuEc2AppExperimental available in GuCDK v59.5.0.

This formalises the changes of #1154, installing the experimental pattern from an NPM release.

How to test

N/A as testing has been performed in #1154.

When using `GuEc2AppExperimental` there is no need to perform the `deploy` action of the `autoscaling` deployment type from Riff-Raff.
@akash1810
Copy link
Member Author

Successfully deployed.

@akash1810 akash1810 requested a review from a team September 18, 2024 09:09
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This is a requirement for using `GuEc2AppExperimental`.
This offers increased clarity.
@akash1810 akash1810 merged commit d77bd52 into main Sep 18, 2024
4 checks passed
@akash1810 akash1810 deleted the aa/cfn-deploy-proper branch September 18, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants