-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Perform EC2 deployments via CloudFormation #1156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `GuEc2AppExperimental` there is no need to perform the `deploy` action of the `autoscaling` deployment type from Riff-Raff.
tjsilver
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
akash1810
force-pushed
the
aa/cfn-deploy-proper
branch
from
September 18, 2024 09:50
b971141
to
272b424
Compare
This is a requirement for using `GuEc2AppExperimental`.
akash1810
force-pushed
the
aa/cfn-deploy-proper
branch
from
September 18, 2024 09:52
272b424
to
664d5c5
Compare
This offers increased clarity.
akash1810
force-pushed
the
aa/cfn-deploy-proper
branch
from
September 18, 2024 10:07
bfb4c74
to
8211507
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses the new
GuEc2AppExperimental
available in GuCDK v59.5.0.This formalises the changes of #1154, installing the experimental pattern from an NPM release.
How to test
N/A as testing has been performed in #1154.