TooTallToby tutorials: unbreak and test. #912
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @jdegenstein. LMK if you'd rather I not replace your PPP0110 solution (and if you have a fix in mind already). |
- Unbreak the three broken tutorials (fixes gumyr#848) - This involved a rewrite of PPP-01-10 because I already had my own solution to that one and I couldn't easily tell what was going wrong with the previous solution. - Add assertions to all the tutorials so that non-raising means success - Add the TTT examples to `test_examples.py` added recently for gumyr#909 - Also added sympy to development dependencies since one of the TTT examples uses it.
fischman
force-pushed
the
ttt-unbreak-and-test
branch
from
7b9c87f to
3e8bb44
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #912 +/- ##
==========================================
+ Coverage 96.73% 96.91% +0.18%
==========================================
Files 32 32
Lines 9434 9434
==========================================
+ Hits 9126 9143 +17
+ Misses 308 291 -17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_examples.pyadded recently for Examples should be kept working by being run in a test #909dos2unix'd the TTT .py files to match the rest of the codebase.