allow to enabled/disable gc deletes internally

gustavobmaia · Dec 8, 2011 · ba29160 · ba29160
1 parent df9f333
commit ba29160
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/src/main/java/org/elasticsearch/index/engine/Engine.java b/src/main/java/org/elasticsearch/index/engine/Engine.java
@@ -56,6 +56,8 @@ public interface Engine extends IndexShardComponent, CloseableComponent {
      */
     TimeValue defaultRefreshInterval();
 
+    void enableGcDeletes(boolean enableGcDeletes);
+
     void updateIndexingBufferSize(ByteSizeValue indexingBufferSize);
 
     void addFailedEngineListener(FailedEngineListener listener);

diff --git a/src/main/java/org/elasticsearch/index/engine/robin/RobinEngine.java b/src/main/java/org/elasticsearch/index/engine/robin/RobinEngine.java
@@ -92,6 +92,8 @@ public class RobinEngine extends AbstractIndexShardComponent implements Engine {
 
     private long gcDeletesInMillis;
 
+    private volatile boolean enableGcDeletes = true;
+
     private final ThreadPool threadPool;
 
     private final IndexSettingsService indexSettingsService;
@@ -286,6 +288,11 @@ public TimeValue defaultRefreshInterval() {
         return new TimeValue(1, TimeUnit.SECONDS);
     }
 
+    @Override
+    public void enableGcDeletes(boolean enableGcDeletes) {
+        this.enableGcDeletes = enableGcDeletes;
+    }
+
     public GetResult get(Get get) throws EngineException {
         rwl.readLock().lock();
         try {
@@ -386,7 +393,7 @@ private void innerCreate(Create create, IndexWriter writer) throws IOException {
                 if (versionValue == null) {
                     currentVersion = loadCurrentVersionFromIndex(create.uid());
                 } else {
-                    if (versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
+                    if (enableGcDeletes && versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
                         currentVersion = -1; // deleted, and GC
                     } else {
                         currentVersion = versionValue.version();
@@ -510,7 +517,7 @@ private void innerIndex(Index index, IndexWriter writer) throws IOException {
                 if (versionValue == null) {
                     currentVersion = loadCurrentVersionFromIndex(index.uid());
                 } else {
-                    if (versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
+                    if (enableGcDeletes && versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
                         currentVersion = -1; // deleted, and GC
                     } else {
                         currentVersion = versionValue.version();
@@ -625,7 +632,7 @@ private void innerDelete(Delete delete, IndexWriter writer) throws IOException {
                 if (versionValue == null) {
                     currentVersion = loadCurrentVersionFromIndex(delete.uid());
                 } else {
-                    if (versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
+                    if (enableGcDeletes && versionValue.delete() && (threadPool.estimatedTimeInMillis() - versionValue.time()) > gcDeletesInMillis) {
                         currentVersion = -1; // deleted, and GC
                     } else {
                         currentVersion = versionValue.version();
@@ -940,7 +947,7 @@ private void refreshVersioningTable(long time) {
                     continue; // its a newer value, from after/during we refreshed, don't clear it
                 }
                 if (versionValue.delete()) {
-                    if ((time - versionValue.time()) > gcDeletesInMillis) {
+                    if (enableGcDeletes && (time - versionValue.time()) > gcDeletesInMillis) {
                         versionMap.remove(id);
                     }
                 } else {