Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: docker-compose.yml has been updated to pull the test image from dockerhub #7359

Draft
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Draft

Draft: docker-compose.yml has been updated to pull the test image from dockerhub #7359

wants to merge 1 commit into from

Conversation

roslynwythe
Copy link
Member

@roslynwythe roslynwythe commented Aug 26, 2024 •
edited
Loading

Fixes #7358

What changes did you make?

  • updated docker-compose.yml to reference hackforlaops/ghpages:testing
  • for history behind hackforlaops/ghpages:testing see

Why did you make the changes (we will use this info to test)?

  • When docker-compose up runs it will pull down the test image, recreate the container, build and server the site so that we can test

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Aug 26, 2024
@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b roslynwythe-test-docker-image-ops-142 gh-pages
git pull https://github.com/roslynwythe/website.git test-docker-image-ops-142

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less Feature: Docker and removed Draft Issue is still in the process of being created labels Aug 26, 2024
@roslynwythe roslynwythe mentioned this pull request Aug 26, 2024
Open
@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Aug 27, 2024
@roslynwythe roslynwythe marked this pull request as draft August 27, 2024 00:10
@roslynwythe roslynwythe removed the Draft Issue is still in the process of being created label Aug 27, 2024
@andyphancode andyphancode requested review from andyphancode and removed request for andyphancode August 30, 2024 21:43
@vorleakyek vorleakyek self-requested a review August 31, 2024 04:44
@vorleakyek
Copy link
Member

Review ETA: 9/1
Availability: M-F evening

vorleakyek
vorleakyek approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes align with the ticket description, and the images on the website are loading fine in the local testing environment.

Thank you for working on this ticket.

@vorleakyek vorleakyek mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vorleakyek vorleakyek vorleakyek approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Docker role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
HfLA Website: Project Board
Status: test-approved-by-reviewer (Automated Column, do not place items here manually)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local testing of new dockerhub image
3 participants
@roslynwythe @vorleakyek @andyphancode