Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing instances of "test" as a substring in the events page - #6369 #7464

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

dcotelessa
Copy link
Member

Fixes #6369

What changes did you make?

  • Created new function to filter VRMS data based on "test" found in the entry name (case-insensitive)
  • Applied the function to the VRMS data
  • Checked the events page to see test entried removed

Why did you make the changes (we will use this info to test)?

  • On /assets/js/utility/vrms-events.js, the code-block rendering events from the VRMS to the website contain "test" events
  • These test events are idenitified by "test" found in the entry name (case-insensitive)
  • On Docker, the filtering of "test" events can be seen on http://localhost:4000/events/

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dcotelessa-remove-test-vrms-events-6369 gh-pages
git pull https://github.com/dcotelessa/website-hackforla.git remove-test-vrms-events-6369

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe P-Feature: Events https://www.hackforla.org/events/ size: 0.5pt Can be done in 3 hours or less labels Sep 16, 2024
@dcotelessa
Copy link
Member Author

ETA: 2 hrs
Availability: 3-5pm M-F

@codyyjxn codyyjxn self-requested a review September 16, 2024 19:42
@vorleakyek vorleakyek self-requested a review September 17, 2024 06:28
@vorleakyek
Copy link
Member

Review ETA: by Thursday (9/19) or Friday (9/20)
Availability: M-F evening

codyyjxn
codyyjxn previously approved these changes Sep 18, 2024
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcotelessa Great job on taking on this issue. The changes are clear and the title is also concise on the tings that were changed. I ran the test and everything seemed to work as intended.

Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on adding the vrmsDataFilter function. But, we should update the variable name "vrmsData" to "vrmsDataFilter" in the comment to avoid any confusion later.

assets/js/utility/vrms-events.js Outdated Show resolved Hide resolved
@dcotelessa
Copy link
Member Author

Wanted to mention this is only /events page and not /events-check page that also uses vrmsData to show events.

codyyjxn
codyyjxn previously approved these changes Sep 21, 2024
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcotelessa Nice work!

  1. The function you developed is clear and easy to follow.
  2. You applied it to the VRMS data accurately.
  3. Including the before-and-after process effectively highlights the changes made.
  4. Your thoughtful approach makes it easy for others to understand your work.

Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that "Test-EventName" is no longer showing up on the events page on the Hack for LA website. Thanks!

@daras-cu daras-cu merged commit d45ca48 into hackforla:gh-pages Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Removing instances of "test" as a substring in the events page
4 participants