Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:feat: implement comment notifications for link page #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 27, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

为 link 页面新增评论通知。

How to test it?

测试在 link 页面进行评论后是否会发送邮件通知。

Which issue(s) this PR fixes:

Fixes #82
Fixes #89

Does this PR introduce a user-facing change?

为 Link 页面新增评论通知

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby August 27, 2024 07:59
Copy link

f2c-ci-robot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LIlGG LIlGG changed the title feat: implement comment notifications for link page WIP:feat: implement comment notifications for link page Aug 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@JohnNiang
Copy link
Collaborator

Hi @LIlGG , 请问当前 PR 遇到了什么问题么?

1 similar comment
@ruibaby
Copy link
Member

ruibaby commented Nov 5, 2024

Hi @LIlGG , 请问当前 PR 遇到了什么问题么?

@guqing
Copy link
Member

guqing commented Nov 12, 2024

/ping @LIlGG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
4 participants