Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simpleCellAddressFromString crashes when called with non-ASCII character on an unquoted sheet name #1314

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Sep 26, 2023

Context

simpleCellAddressFromString will return undefined when called with invalid cell address (regexp matching fails).

How did you test your changes?

  • unit tests passed
  • new unit tests for this issue
  • built & reviewed docs locally

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1312

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba requested a review from evanSe September 26, 2023 12:24
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Performance comparison of head (c66c5c7) vs base (4f768fd)

                                     testName |    base |    head |  change
---------------------------------------------------------------------------
                                      Sheet A | 1060.42 | 1047.36 |  -1.23%
                                      Sheet B |     388 |  389.13 |  +0.29%
                                      Sheet T |  335.84 |  328.82 |  -2.09%
                                Column ranges |  978.79 |   983.1 |  +0.44%
Sheet A:  change value, add/remove row/column |      81 |      73 |  -9.88%
 Sheet B: change value, add/remove row/column |     561 |     510 |  -9.09%
                   Column ranges - add column |     317 |     323 |  +1.89%
                Column ranges - without batch |    1278 |     870 | -31.92%
                        Column ranges - batch |     203 |     236 | +16.26%

Copy link
Contributor

@evanSe evanSe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great 👍🏻

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1314 (c66c5c7) into develop (4f768fd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1314   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14420    14422    +2     
  Branches      3017     3018    +1     
========================================
+ Hits         14027    14029    +2     
  Misses         393      393           
Files Coverage Δ
src/HyperFormula.ts 99.59% <100.00%> (ø)
src/parser/addressRepresentationConverters.ts 97.52% <100.00%> (+0.04%) ⬆️

@sequba sequba merged commit cc5a59f into develop Oct 4, 2023
23 checks passed
@sequba sequba deleted the feature/issue-1312 branch October 4, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: simpleCellAddressFromString crashes when called with non-ASCII character on an unquoted sheet name
2 participants