Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 demo #1318

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Vue 3 demo #1318

merged 2 commits into from
Oct 4, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Sep 29, 2023

Context

This PR adds a new page to the documentation with the Vue 3 demo. The existing Vue demo is renamed to Vue 2 demo.

Should be merged together with handsontable/hyperformula-demos#20

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1275

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Sep 29, 2023
@sequba sequba linked an issue Sep 29, 2023 that may be closed by this pull request
5 tasks
@sequba sequba requested a review from evanSe September 29, 2023 16:41
@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Performance comparison of head (bd27bab) vs base (0661cdb)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A |  755.8 |  751.4 |  -0.58%
                                      Sheet B | 254.06 | 260.29 |  +2.45%
                                      Sheet T |  224.2 | 226.45 |  +1.00%
                                Column ranges | 820.89 | 831.01 |  +1.23%
Sheet A:  change value, add/remove row/column |     60 |     53 | -11.67%
 Sheet B: change value, add/remove row/column |    420 |    412 |  -1.90%
                   Column ranges - add column |    429 |    234 | -45.45%
                Column ranges - without batch |    707 |    572 | -19.09%
                        Column ranges - batch |    152 |    184 | +21.05%

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1318 (bd27bab) into develop (0661cdb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1318   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14420    14420           
  Branches      3080     3017   -63     
========================================
  Hits         14027    14027           
- Misses         388      393    +5     
+ Partials         5        0    -5     

see 3 files with indirect coverage changes

@sequba sequba merged commit 4f768fd into develop Oct 4, 2023
21 checks passed
@sequba sequba deleted the feature/issue-1275 branch October 4, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vue 3 demo
1 participant