Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-import-controller Change StorageClassName to StorageClass #1008

Open
wants to merge 1 commit into
base: release-harvester-v1.2.2-rc1
Choose a base branch
from

Conversation

abonillabeeche
Copy link

Change StorageClassName to StorageClass to match the chart

Summary

The UI asks for a StorageClass but we pass a StorageClassName, which has no match. Therefore the chart uses the default StorageClass.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes #

While creating a custom migration scenario, we observed the preferred StorageClass wasn't in use. After looking into it, Gaurav pointed out the incorrect syntax was used.

Areas or cases that should be tested

Upgrade from 1.2.1, then edit and Save the AddOn.

Areas which could experience regressions

This change, when Saved, will create another PVC and delete the old one in the correct StorageClass as orignally defined vs the default SC. It could cause disk utilization issues if the user expected them somewhere else (which was originally wrong)

Change StorageClassName to StorageClass to match the chart
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abonillabeeche . Is the bug affecting only the 1.2 version? in this case, could you please change the target branch? It should be release-harvester-v1.2.
Otherwise we should push on master and create the backports afterward.

@a110605 a110605 added the Enhancement minor or greater UI enhancement label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement minor or greater UI enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants