-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port app-modal to harvester shell (backport #1163) (Target v1.3, Testing) #1197
base: release-harvester-v1.3
Are you sure you want to change the base?
Port app-modal to harvester shell (backport #1163) (Target v1.3, Testing) #1197
Conversation
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 85b311d) # Conflicts: # pkg/harvester/edit/kubevirt.io.virtualmachine/index.vue # pkg/harvester/l10n/en-us.yaml
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 5f65595) # Conflicts: # pkg/harvester/l10n/en-us.yaml
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 874e191) # Conflicts: # pkg/harvester/edit/harvesterhci.io.host/HarvesterDisk.vue
Cherry-pick of 85b311d has failed:
Cherry-pick of 5f65595 has failed:
Cherry-pick of 874e191 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: andy.lee <[email protected]>
I am still testing this PR change against v1.3.2 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Summary
Rancher dashboard has already replace
<modal>
to<app-modal>
in below two PRsPromptModal.vue
rancher/dashboard#10556vue-js-modal
withapp-modal
rancher/dashboard#10591PR Checklist
Related Issue #
[BUG] Can't select the harvester version to upgrade in Rancher UI
[BUG] Rancher doesn't use dark mode in popup modals when in Harvester UI
Screenshot/Video
I've tested harvester
Test on embedded mode
This is an automatic backport of pull request #1163 done by [Mergify](https://mergify.com).