HARVESTER: Fix IP Pool Same Namespace Can Be Added Multiple Times #906
Conversation
| return [{ | ||
| label: this.t('generic.all'), | ||
| value: '*', |
There was a problem hiding this comment.
"All" should encompass all scenarios, which means that when a user selects "All," the other options cannot be chosen, including selecting "All" twice.
There was a problem hiding this comment.
I agree with the de-duplication of , but I have a different opinion on the AllAll and default scenario
I can not de-duplication All because the option All label is not the same as the value.
As a selector, the option "all" is mutually exclusive with other options, which makes it difficult to interact on UX.
For example, when I add the first selector, the default namespace value is All, is it not allowed to add namespace default in this scenario?
| @@ -199,7 +204,7 @@ export default { | |||
| <Select | |||
| v-else | |||
| v-model="row.namespace" | |||
| :options="namespaceOptions" | |||
| :options="showProjectAndCluster ? namespaceOptions : uniqNamespaceOptions" | |||
There was a problem hiding this comment.
Perhaps filtering duplicate namespaces is also necessary for multiple clusters.
There was a problem hiding this comment.
The guest cluster will have more than one under the same namespace, and it doesn't make sense to de-emphasize the namespace.
n313893254
force-pushed
the
fix-ip-pool
branch
from
4414687
to
e78d9eb
Compare
Summary
PR Checklist
- Is this a multi-tenancy feature/bug?- [ ] Yes, the relevant RBAC changes are at:
- Do we need to backport changes to the old Rancher UI, such as RKE1?- [ ] Yes, the relevant PR is at:
- Are backend engineers aware of UI changes?- [ ] Yes, the backend owner is:
- [ ]
Fix IP Pool Same Namespace Can Be Added Multiple Times
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video