Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollback PR CodeCov breaking change -- Don't Merge #559

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: rollback PR CodeCov breaking change -- Don't Merge #559

wants to merge 1 commit into from

Conversation

AlfredoG87
Copy link
Contributor

Description:
This this upgrade cause the disappearance of CodeCov reports

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 added this to the 0.4.0 milestone Jan 31, 2025
@AlfredoG87 AlfredoG87 added Release Issues tied to release management functions Improvement Code changes driven by non business requirements labels Jan 31, 2025
@AlfredoG87 AlfredoG87 self-assigned this Jan 31, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review January 31, 2025 05:27
@AlfredoG87 AlfredoG87 requested review from a team as code owners January 31, 2025 05:27
@AlfredoG87 AlfredoG87 added Bug A error that causes the feature to behave differently than what was expected based on design docs and removed Improvement Code changes driven by non business requirements labels Jan 31, 2025
@andrewb1269hg andrewb1269hg self-requested a review January 31, 2025 20:21
@andrewb1269hg
Copy link
Contributor

Please do not merge this PR.

andrewb1269hg
andrewb1269hg requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to investigate why this is breaking. There is nothing in this action upgrade that should be breaking things.

@AlfredoG87
Copy link
Contributor Author

We need to investigate why this is breaking. There is nothing in this action upgrade that should be breaking things.

Yeah, I wanted to see if this restored the CodeCov report on PRs but at least on this PR does not seem to have worked....
However the upgrade coincides with the latest report that was sent to CodeCov, if you have some time we can meet and I can show you what I mean.

@AlfredoG87 AlfredoG87 changed the title fix: rollback breaking change fix: rollback PR CodeCov breaking change -- Don't Merge Feb 11, 2025
@AlfredoG87 AlfredoG87 marked this pull request as draft February 11, 2025 20:02
@AlfredoG87 AlfredoG87 modified the milestones: 0.4.0, 0.6.0 Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewb1269hg andrewb1269hg andrewb1269hg requested changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

@rbarker-dev rbarker-dev Awaiting requested review from rbarker-dev

Requested changes must be addressed to merge this pull request.

Assignees

@AlfredoG87 AlfredoG87

Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Release Issues tied to release management functions
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlfredoG87 @andrewb1269hg