fix: attempt to fix hiero dependency runtime to compile time only. #635
Conversation
AlfredoG87
added
Block Node
server/build.gradle.kts
Outdated
| @@ -31,7 +32,7 @@ testModuleInfo { | |||
| requires("org.mockito") | |||
| requires("org.mockito.junit.jupiter") | |||
| requires("org.assertj.core") | |||
| requiresStatic("com.github.spotbugs.annotations") | |||
There was a problem hiding this comment.
This change is wrong. Having com.github.spotbugs.annotations as requiresStatic is correct in general. My assumption is that any dependency brings it in as a non-static transitive dependency. I will have a look again to give more information
There was a problem hiding this comment.
I just did a force push with try number 2 😅
Let me know if this fixes it, also, it would be nice to know if the analysis is something I can do locally on my branch.
There was a problem hiding this comment.
This change should be irrelevant for the runtime classpath. I expect that it would not change anything on the result.
As I explained here, there is nothing bringing it in transitive:
hiero-ledger/tsc#85 (comment)
You can check the build scans yourself if you have doubts.
There was a problem hiding this comment.
@jjohannes what is the mainRuntimeClasspath?
There was a problem hiding this comment.
Okay I see the confusion. The name is not great for how we use it now. I should probably check if we can change it to something else that does not contain the term "RuntimeClasspath". It is used internally in the Gradle setup to create a "global scope" across all Modules using a few Gradle tricks. The goal is to have the same dependencies and versions available everywhere which we need for the Jar module-info patching. In the past it was only based on the runtime classpath (hence the name). But we noticed that sometimes the Jar patching was missing information about versions, which was because of "require static" (compileOnly) dependencies like this one that also needed patching.
Bottom line: This is something used internally for version consistency across all module of a project.
For the license check, we should only look at the standard runtimeClasspath.
There was a problem hiding this comment.
@jjohannes Thank you for the help and clarification! 🙏
@hendrikebbers, so we should be good then?
Signed-off-by: Alfredo Gutierrez <[email protected]>
Reviewer Notes
See the following issue: hiero-ledger/tsc#85
Related Issue(s)