feat: Add Telemetry logic #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
Signed-off-by: Michiel Mulders <[email protected]>
jaycoolh
approved these changes
Feb 14, 2025
swirlds-automation
added a commit
that referenced
this pull request
Feb 14, 2025
## [0.3.0](v0.2.0...v0.3.0) (2025-02-14) ### Features * Add Telemetry logic ([#605](#605)) ([89120a0](89120a0))
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bguiz
reviewed
Feb 15, 2025
There was a problem hiding this comment.
I see this block repeated in all of the commands:
await telemetryUtils.recordCommand(command.join(' '));
}
stateUtils.recordCommand(command);```
2 suggestions regarding this:
* a better design pattern might be to shift the invocation of `telemetryUtils.recordCommand` inside of the impl of `stateUtils.recordCommand`
* whether you shift it inside or not, consider whether you want to `await` the invocation of `telemetryUtils.recordCommand` ... does the rest of the command really need to wait for the telemetry to be logged?
* if no, which I think is the case since this is logging and not executing any "business logic", then you can simply fire and forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds telemetry data capture, which is disabled by default.
The documents have been updated to notify people about what we capture and how to enable it if they want to give us data.