Skip to content

Commit

Permalink
build: set registry-url in GHA workflow to enable publishing (#180)
Browse files Browse the repository at this point in the history
Signed-off-by: Luis Mastrangelo <[email protected]>
  • Loading branch information
acuarica authored Jan 10, 2025
1 parent 4609c32 commit 238c1ee
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 1,275 deletions.
1 change: 1 addition & 0 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
with:
node-version: '20'
registry-url: 'https://registry.npmjs.org'

- name: Install Foundry
uses: step-security/foundry-toolchain@01e2d127ea061e2ce8fa34340de71ca8518f093e # v1.2.1
Expand Down
5 changes: 1 addition & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@

# Foundry's cache and compiler output files
/cache/
/out/*

# HTS compiler output needed for `npm` package when consumed directly from GitHub
!/out/HtsSystemContract.sol/
/out/

.idea/

Expand Down
1,270 changes: 0 additions & 1,270 deletions out/HtsSystemContract.sol/HtsSystemContract.json

This file was deleted.

2 changes: 1 addition & 1 deletion test/ERC721.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ contract ERC721TokenTest is Test, TestSetup, IERC721Events, IERC20Events {
assertEq(IERC721(CFNFTFF).getApproved(tokenId), CFNFTFF_ALLOWED_SPENDER);
}

function test_ERC721_isApprovedForAll() external {
function test_ERC721_isApprovedForAll() external view {
assertFalse(IERC721(CFNFTFF).isApprovedForAll(CFNFTFF_TREASURY, CFNFTFF_ALLOWED_SPENDER));
}

Expand Down

0 comments on commit 238c1ee

Please sign in to comment.