feat: implementing hts crypto transfer method (#195) #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arianejasuwienas
changed the base branch from
195-crypto-transfer-support
to
main
arianejasuwienas
changed the title
arianejasuwienas
force-pushed
the
195-crypto-transfer-support-with-approval
branch
from
2d7b854 to
e609cb3
Compare
arianejasuwienas
added
the
feature
arianejasuwienas
force-pushed
the
195-crypto-transfer-support-with-approval
branch
from
e609cb3 to
cfc904c
Compare
arianejasuwienas
changed the title
andrewb1269hg
previously approved these changes
Jan 30, 2025
andrewb1269hg
previously approved these changes
Feb 3, 2025
acuarica
reviewed
Feb 3, 2025
| @@ -0,0 +1,75 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
we need to export this interface (and others like IERC20/IERC721) from contracts/.
Opened a ticket here #227
| defaultNetwork: 'testnet', | ||
| networks: { | ||
| hardhat: { | ||
| allowUnlimitedContractSize: true, |
| @@ -0,0 +1,50 @@ | |||
| /*- | |||
There was a problem hiding this comment.
we already have a Hardhat example, we should include this test in there.
| const hre = require('hardhat'); | ||
| const { expect } = require('chai'); | ||
|
|
||
| describe('RPC', function () { |
There was a problem hiding this comment.
maybe something like
Suggested change
| describe('RPC', function () { | |
| describe('cryptoTransfer', function () { |
Comment on lines
42
to
47
| testnet: { | ||
| url: 'https://testnet.hashio.io/api', | ||
| accounts: process.env.TESTNET_OPERATOR_PRIVATE_KEY | ||
| ? [process.env.TESTNET_OPERATOR_PRIVATE_KEY] | ||
| : [], | ||
| chainId: 296, |
There was a problem hiding this comment.
this should be setup as forking. Otherwise, it's an internal test, not an example test.
There was a problem hiding this comment.
Yes, it was more of an internal test. This feature (hbar transfer) will not work in the fork when using hardhat, even with our plugin. It relies on the foundry cheatcodes. I'll just remove this example for now.
acuarica
requested changes
Feb 3, 2025
2 tasks
arianejasuwienas
force-pushed
the
195-crypto-transfer-support-with-approval
branch
from
d40cee7 to
7b915e4
Compare
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
… was not using forks (#195) Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
force-pushed
the
195-crypto-transfer-support-with-approval
branch
from
8bc5217 to
8270fd2
Compare
Signed-off-by: Mariusz Jasuwienas <[email protected]>
|
@acuarica is there anything else we want to focus on in this PR? |
|
Once we are done with pending PRs, I'm going to take a look. |
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allows users to call crypto transfer method on the HTS (0x167) address. Since the method is non-payable only foundry solution / library will support hbar transfers (through the vm cheat codes).
Related issue(s):
Fixes #195
Notes for reviewer:
Checklist