-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed eth_getCode to now use blockNumber when address is an HTS token #3433
Conversation
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 19 files - 7 240 suites - 111 33m 23s ⏱️ - 38m 33s For more details on these failures, see this check. Results for commit 599386c. ± Comparison against base commit 3e057b5. ♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
packages/relay/src/lib/services/ethService/ethCommonService/index.ts
Outdated
Show resolved
Hide resolved
packages/relay/src/lib/services/ethService/ethCommonService/index.ts
Outdated
Show resolved
Hide resolved
…ests + acceptance tests Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
@acuarica please kindly take a look when you have a chance to see if it meet yoru original requirements. Thanks much! |
…d on tests Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
… to mirror node Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always! Just some questions and suggestions.
Signed-off-by: Simeon Nakov <[email protected]>
e7a831d
to
7a921e3
Compare
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
+ Coverage 84.46% 85.48% +1.02%
==========================================
Files 69 69
Lines 4751 4734 -17
Branches 1059 999 -60
==========================================
+ Hits 4013 4047 +34
+ Misses 426 400 -26
+ Partials 312 287 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
If we pass an HTS token address to getCode, we do not take into account the block number, resulting in a bug where it would return the smart contract code even if the block number provided is earlier than the one where the token was created.
Related issue(s):
Fixes #3155
Notes for reviewer:
Checklist