Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch license declarations to SPDX #3479

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Feb 17, 2025

Description:

Change all license declarations to SPDX format.

Related issue(s):

Fixes: #3480

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <[email protected]>
Copy link

github-actions bot commented Feb 17, 2025

Test Results

 18 files   -  10  236 suites   - 167   33m 19s ⏱️ - 1h 3m 28s
617 tests + 31  613 ✅ + 52  4 💤 +2  0 ❌  - 23 
633 runs   - 482  629 ✅  - 450  4 💤  - 2  0 ❌  - 30 

Results for commit e73d2dd. ± Comparison against base commit 4406824.

This pull request removes 8 and adds 39 tests. Note that renamed tests count towards both.
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before all" hook in "HBAR Rate Limit Tests" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests "before all" hook in "HBAR Rate Limit Tests"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes without passing block" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes without passing block"
"before each" hook for "should execute "eth_getUncleByBlockHashAndIndex"" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getUncleByBlockHashAndIndex""
"before each" hook for "should return 0x0 for account evm_address on eth_getCode" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should return 0x0 for account evm_address on eth_getCode"
@release should be able to debug a failing CALL transaction of type 1559 with call depth and onlyTopCall false ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transactions of type: 2 @release should be able to debug a failing CALL transaction of type 1559 with call depth and onlyTopCall false
@release should be able to debug a failing CREATE transaction of type 1559 with call depth and onlyTopCall false ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transactions of type: 2 @release should be able to debug a failing CREATE transaction of type 1559 with call depth and onlyTopCall false
@release should be able to debug a successful CALL transaction of type 1559 with call depth and onlyTopCall true ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transactions of type: 2 @release should be able to debug a successful CALL transaction of type 1559 with call depth and onlyTopCall true
@release should be able to debug a successful CREATE transaction of type 1559 with call depth and onlyTopCall true ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transactions of type: 2 @release should be able to debug a successful CREATE transaction of type 1559 with call depth and onlyTopCall true
from/to Addresses in transaction between accounts are in evm format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses in transaction between accounts are in evm format
from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses in transaction to a contract (deployed through HAPI tx) are in evm and long-zero format
from/to Addresses in transaction to a contract (deployed through the relay) are in evm and long-zero format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses in transaction to a contract (deployed through the relay) are in evm and long-zero format
from/to Addresses when transferring HTS tokens to the tokenAddress are in evm and long-zero format ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests Formats of addresses in Transaction and Receipt results from/to Addresses when transferring HTS tokens to the tokenAddress are in evm and long-zero format
should be able to debug a failing CALL transaction of type 1559 with call depth and onlyTopCall true ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transactions of type: 2 should be able to debug a failing CALL transaction of type 1559 with call depth and onlyTopCall true
should be able to debug a failing CALL transaction of type 2930 with call depth and onlyTopCall false ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite Positive scenarios Test transaction of type 1 should be able to debug a failing CALL transaction of type 2930 with call depth and onlyTopCall false
…

♻️ This comment has been updated with latest results.

@natanasow natanasow self-assigned this Feb 17, 2025
@natanasow natanasow added the enhancement New feature or request label Feb 17, 2025
@natanasow natanasow added this to the 0.67.0 milestone Feb 17, 2025
@natanasow natanasow marked this pull request as ready for review February 17, 2025 13:46
Copy link
Collaborator

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow merged commit ef2d8bb into main Feb 17, 2025
48 of 50 checks passed
@natanasow natanasow deleted the 1150-switch-license-to-spdx branch February 17, 2025 17:46
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (4406824) to head (e73d2dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   85.17%   85.57%   +0.40%     
==========================================
  Files          69       69              
  Lines        4734     4734              
  Branches      999      999              
==========================================
+ Hits         4032     4051      +19     
+ Misses        409      398      -11     
+ Partials      293      285       -8     
Flag Coverage Δ
config-service 95.16% <ø> (ø)
relay 79.54% <ø> (ø)
server 83.60% <ø> (ø)
ws-server 36.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/config-service/src/services/globalConfig.ts 100.00% <ø> (ø)
packages/config-service/src/services/index.ts 92.85% <ø> (ø)
...kages/config-service/src/services/loggerService.ts 90.00% <ø> (ø)
...s/config-service/src/services/validationService.ts 100.00% <ø> (ø)
packages/relay/src/formatters.ts 72.04% <ø> (ø)
packages/relay/src/index.ts 100.00% <ø> (ø)
...kages/relay/src/lib/clients/cache/localLRUCache.ts 92.53% <ø> (ø)
packages/relay/src/lib/clients/cache/redisCache.ts 87.03% <ø> (ø)
packages/relay/src/lib/clients/index.ts 100.00% <ø> (ø)
packages/relay/src/lib/clients/mirrorNodeClient.ts 89.63% <ø> (+0.40%) ⬆️
... and 59 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch license declarations to SPDX
3 participants