-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduced TTL for feeHistory, getTinyBarGasFee, and getPrice #3482
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 20 files - 8 290 suites - 113 35m 27s ⏱️ - 1h 1m 20s For more details on these failures, see this check. Results for commit f5035eb. ± Comparison against base commit 4406824. This pull request removes 8 and adds 41 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
@simzzz, the PR description doesn’t explain how lowering the TTL would help resolve the issue. Additionally, there are no end-to-end tests to verify the fix. Could you update the description with more details on how this change addresses the problem? If possible, adding e2e tests would be beneficial to prevent regressions. Thanks! |
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3482 +/- ##
==========================================
+ Coverage 85.17% 85.61% +0.44%
==========================================
Files 69 69
Lines 4734 4735 +1
Branches 999 999
==========================================
+ Hits 4032 4054 +22
+ Misses 409 396 -13
+ Partials 293 285 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
This PR reduces the TTL for caching fee history, gas fee, and gas price in an attempt to reduce the likelihood of INSUFFICIENT_TX_FEE errors.
We suspect that a reason that some transactions fail is because there is a fluctuation on the network gas price, while we return the cached value resulting in a too low gas estimation. By reducing the TTL in a few places where the gas fee is used it would reduce the likelihood of such problem.
Related issue(s):
#3283
Notes for reviewer:
Checklist