Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes flaky CI tests #3495

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix: fixes flaky CI tests #3495

wants to merge 6 commits into from

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Feb 18, 2025

Description:
This PR attempts to fix the flaky CI tests, the main cause for the first test mentioned to be flaky was

Error: transaction must have been frozen before calculating the hash will be stable, try calling freeze``

By separating the freezing and signing and increasing the timeout slightly the test now passed 3 times in a row in the CI.
I didn't get a timeout for The beforeAll() block in the eth_getCode suite is timing out.

Related issue(s):

Fixes partially #3353

Notes for reviewer:

Checklist

@simzzz simzzz self-assigned this Feb 18, 2025
@simzzz simzzz added the bug Something isn't working label Feb 18, 2025
@simzzz simzzz added this to the 0.67.0 milestone Feb 18, 2025
Copy link

github-actions bot commented Feb 18, 2025

Test Results

 20 files  + 1  269 suites  +15   40m 47s ⏱️ + 4m 18s
617 tests + 7  610 ✅ + 6  4 💤 ±0  3 ❌ +1 
813 runs  +86  804 ✅ +85  6 💤 ±0  3 ❌ +1 

For more details on these failures, see this check.

Results for commit 454e3f4. ± Comparison against base commit ef2d8bb.

This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both.
"before all" hook in "@erc20 Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests "before all" hook in "@erc20 Acceptance Tests"
Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers EXTENDED Tier Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget
Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers PRIVILEGED Tier Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget
Should eventually exhaust the hbar limit for EXTENDED user and still allow another EXTENDED user to make calls ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers EXTENDED Tier Should eventually exhaust the hbar limit for EXTENDED user and still allow another EXTENDED user to make calls
Should eventually exhaust the hbar limit for PRIVILEGED user and still allow another PRIVILEGED user to make calls ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers PRIVILEGED Tier Should eventually exhaust the hbar limit for PRIVILEGED user and still allow another PRIVILEGED user to make calls
Should increase the amount spent of the spending plan by the transaction cost ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers EXTENDED Tier Should increase the amount spent of the spending plan by the transaction cost
Should increase the amount spent of the spending plan by the transaction cost ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers PRIVILEGED Tier Should increase the amount spent of the spending plan by the transaction cost
should create a BASIC spending plan for a new user and use the same plan on second transaction and different plan on third transaction from another user ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 BASIC Tier should create a BASIC spending plan for a new user and use the same plan on second transaction and different plan on third transaction from another user
should eventually exhaust the hbar limit for a BASIC user after multiple deployments of large contracts ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 BASIC Tier should eventually exhaust the hbar limit for a BASIC user after multiple deployments of large contracts

♻️ This comment has been updated with latest results.

Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (4406824) to head (454e3f4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3495      +/-   ##
==========================================
+ Coverage   85.17%   87.50%   +2.33%     
==========================================
  Files          69       65       -4     
  Lines        4734     4555     -179     
  Branches      999      980      -19     
==========================================
- Hits         4032     3986      -46     
+ Misses        409      285     -124     
+ Partials      293      284       -9     
Flag Coverage Δ
config-service 95.16% <ø> (ø)
relay 79.54% <ø> (ø)
server 83.60% <ø> (ø)
ws-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 69 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant