-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes flaky CI tests #3495
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 20 files + 1 269 suites +15 40m 47s ⏱️ + 4m 18s For more details on these failures, see this check. Results for commit 454e3f4. ± Comparison against base commit ef2d8bb. This pull request removes 1 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
+ Coverage 85.17% 87.50% +2.33%
==========================================
Files 69 65 -4
Lines 4734 4555 -179
Branches 999 980 -19
==========================================
- Hits 4032 3986 -46
+ Misses 409 285 -124
+ Partials 293 284 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description:
This PR attempts to fix the flaky CI tests, the main cause for the first test mentioned to be flaky was
Error: transaction must have been frozen before calculating the hash will be stable, try calling
freeze``By separating the freezing and signing and increasing the timeout slightly the test now passed 3 times in a row in the CI.
I didn't get a timeout for
The beforeAll() block in the eth_getCode suite is timing out.
Related issue(s):
Fixes partially #3353
Notes for reviewer:
Checklist