Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use <script setup> for TopicDetails.vue #1526

Merged
merged 4 commits into from
Nov 29, 2024
Merged

chore: use <script setup> for TopicDetails.vue #1526

merged 4 commits into from
Nov 29, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Nov 29, 2024

Description:

Trivial changes to migrate the TopicDetails view to <script setup> syntax.

Copy link

github-actions bot commented Nov 29, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.21% 24760 / 32921
🔵 Statements 75.21% 24760 / 32921
🔵 Functions 60.1% 996 / 1657
🔵 Branches 83.85% 4733 / 5644
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/node/NodeTable.vue 96% 58.33% 66.66% 96% 1, 53, 196-199
src/components/values/StringValue.vue 100% 100% 100% 100%
src/pages/TopicDetails.vue 100% 92.59% 100% 100%
Generated in workflow #1481

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit faf583b into main Nov 29, 2024
11 of 12 checks passed
@svienot svienot deleted the script-setup branch November 29, 2024 17:51
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants